[r24] Compiling errors

[RazTK]

Code: Select all

src\win32\win32gliface.cpp(194) : error C2065: 'vid_refreshrate' : undeclared identifier
src\win32\win32gliface.cpp(392) : error C2653: 'Win32GLFRameBuffer' : is not a class or namespace name
src\win32\win32gliface.cpp(394) : error C2065: 'm_Fullscreen' : undeclared identifier
src\win32\fb_ddraw.cpp(228) : warning C4101: 'refresh' : unreferenced local variable

[Enjay]

And, probably not surprisingly, r25

Code: Select all

.\src\win32\win32gliface.cpp(194) : error C2065: 'vid_refreshrate' : undeclared identifier
.\src\win32\win32gliface.cpp(392) : error C2653: 'Win32GLFRameBuffer' : is not a class or namespace name
.\src\win32\win32gliface.cpp(394) : error C2065: 'm_Fullscreen' : undeclared identifier
st_start.cpp
i_crash.cpp
fb_ddraw.cpp
.\src\win32\fb_ddraw.cpp(228) : warning C4101: 'refresh' : unreferenced local variable

[RazTK]

r25 was just the addition of the in-progress garbage collector:

Code: Select all

------------------------------------------------------------------------
r25 | graf | 2008-02-20 18:58:02 +0200 | 1 line

Created a branch to merge in ZDoom's in-development garbage collector without affecting the main trunk.
------------------------------------------------------------------------

No code changes. :>

[Graf Zahl]

r24 was an accidental commit. I just wanted to commit the branches folder and forgot to uncheck the edited files in the GL folder. I just fixed these issues. Please try again but be aware that I haven't compiled everything after r23 myself.

[RazTK]

Okay, now there's just the following warning, but other than that the code compiles. Thanks.

Code: Select all

src\win32\fb_ddraw.cpp(228) : warning C4101: 'refresh' : unreferenced local variable

[Enjay]

Code: Select all

Build: 5 succeeded, 0 failed, 8 up-to-date, 0 skipped

And it even works when I play it. Thanks.

[Enjay]

Code: Select all

src\win32\fb_ddraw.cpp(228) : warning C4101: 'refresh' : unreferenced local variable

Hmmm, I didn't get that. Mine was a release build without cleaning beforehand with r27.

[edit] OK, just tried a debug build and got it. [/edit]

[TheDarkArchon]

It's a fairly harmless warning: All it means is that a local variable in a function is declared but isn't used at all in said function, which means it's essentially bloat.

[Enjay]

Judging by the message, it would have been added as part of the changes for the "Specify a refresh rate for Vid_SetMode" feature request over at Zdoom?

[Graf Zahl]

Okay, now there's just the following warning, but other than that the code compiles. Thanks.

Code: Select all

src\win32\fb_ddraw.cpp(228) : warning C4101: 'refresh' : unreferenced local variable

Fixed in the branch so I won't do anything about that.

[Enjay]

Comparing the two, it is as TDA said, that fb_ddraw.cpp in the trunk has this line "int refresh;" (line 228) and the branch version doesn't.

Presumably ignoring the unreferenced variable is part of what the optimising of a release build does?