BrightMaps turn to black!

[Logan MTM]

[r424] at GZDoom 1.3.13 beta

[spoiler]
[/spoiler]

This happens when tha actor is over Dynamic lights and the Frame have Disablefullbright flag in Brightmaps defs.

I can make a perfect example wad to reproduce this bug if needed!

[Enjay]

I edited the above post to put the images in spoiler tags because they are big and break the forum layout at lower resolutions.

I too have been noticing some odd lighting effects on sprites when dynamic lights hit them. Most of the time it is OK but they sometimes appear a bit too bright and perhaps I have seen something similar on decals (mainly blood splats). Unfortunately, I have not been able to isolate a good test case.

One thing, lighting mode may be relevant. I noticed the effects when using Doom lighting mode and changing mode reduced or removed the effect.

[Rico]

LOS is getting too much trouble [Graphically], my friend? =)

[Enjay]

Here's a video of the kind of thing I'm getting. It may not be the same problem but it is sprites and dynamic lights related.

http://www.zen64060.zen.co.uk/dynamicsprites.wmv

In the video, as I approach the demon corpse in Doom lighting mode, it gets brighter than it should. Then I try all the other lighting modes and they do not show the problem. Finally, back in Doom mode, I have a quick look at a few other sprites to show that it happens pretty commonly on a level that uses lots of dynamic lights.

As I said, I'm sure that I have seen a similar effect on decals too occasionally.

[Graf Zahl]

It's not the same. This one was quite obvious: The brightmap state was not properly checked when applying the dynamic lights so the code thought the sprite was still fullbright and no light processing was done at all.

[Logan MTM]

And... ?

[Enjay]

And... ?

The thread is now in closed bugs and the code has been updated. I'd say it's fixed.

I'll put a new build on line a little bit later on.