Crash on load of quicksaved file

[argv]

Got a mysterious crash bug on loading a save file. I have an autosave that loads successfully, but if I step out of the train car, shoot the imps and zombies in that room, quicksave, and then try to load that save, the game crashes.

Environment:

• Windows 7 64-bit
• Radeon Software 16.8.2 (Crimson Edition)
• GZDoom d655892 (64-bit build from DRD Team dev build site) in OpenGL mode

The load order is as follows. I have archived all of them except doom.wad. Since the archive is too large for this forum, please find it on my Google Drive (SHA2-256: 011b4e8b3e1e867d8bc0968cfdeb0af377dbe3dbd4c4b2ee47e1418d05f12f2b).

1. doom.wad (from The Ultimate Doom via Steam; SHA2-256: 6fdf361847b46228cfebd9f3af09cd844282ac75f3edbb61ca4cb27103ce2e7f)
2. concern.pk3
3. projectbrutality-hg-eaf5ed9396c7.pk3
4. nc_custom_hud_v1.22.pk3
5. NCHUDPB-PATCH-hg-e94f4fb2761a.pk3
6. beamflashlight-hg-de031c882f38.pk3
7. carryable-light-amplification-visor-hg-7764014b507f.pk3
8. carryable-radsuit-hg-7764014b507f.pk3

The archive also contains the offending autosave file, “auto1.zds”, and an example quicksave file that promptly crashes the engine when loaded, “save20.zds”.

The actual crash is at src/p_acs.cpp line 651. In a debug build, the game instead suffers an assertion failure on line 650. I have included a Visual Studio minidump file in the archive, “zdoom.dmp”, in case it's helpful. I was not able to generate a dump with heap; Visual Studio failed with an “invalid pointer” error.

[argv]

I just played to the same point, using the same load order, on GZDoom 2.2.0 (Windows 64-bit). I quicksaved and quickloaded many times throughout. It never crashed. The problem does not seem to exist in that version.

Also, I found another crash-inducing save from a completely different map set (Resurgence, based on Doom 2). Loading this save causes a crash in the same code location. So it's not just that one map from ConCERNed causing it.

[eksfaktr]

I was going to start a new thread, but this seems like it might be related. It looks like any quicksave now is being overwritten by the autosave data. Here's the steps to duplicate and observe:

• Start new game in Doom, etcetera
• Play about a minute into the level
• Quicksave and create a new save file (does regular saving work, or is it even a separate function?)
• Go back into the Load menu and select your save file, note the name and screenshot
• Save should take you back to the start of map01 as a map-start autosave would do

[Graf Zahl]

No, does not happen for me. The quicksave restarts at the exact same position where it was made.

[Graf Zahl]

@argv:

It looks like you forgot the save files in your archive. All that's there aside from the PK3s is a zdoom.dmp.

[Graf Zahl]

Never mind, I found the problem without that help. Just a very minor oversight that only got triggered in rare situations when there were gaps in the ACS global string array.

[argv]

Oh, hell. I'm glad you figured it out, because I don't think I still have those save files. Sorry about that…

[argv]

It looks like you did indeed fix the problem, because I did another playthrough (up to D2TWiD map07) on f1bb767 without any save corruption. Thanks!